chrome/common/extensions/api/test_presubmit/invalid_idl_2.idl - Issue 23512007: Prase IDL files in common/extensions/api PRESUBMIT check.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/api/test_presubmit/invalid_idl_2.idl

Issue 23512007: Prase IDL files in common/extensions/api PRESUBMIT check. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/api/test_presubmit/invalid_idl_1.idl ('K') | « chrome/common/extensions/api/test_presubmit/invalid_idl_1.idl ('k') | chrome/common/extensions/api/test_presubmit/invalid_idl_3.idl » ('j') | chrome/common/extensions/api/test_presubmit/invalid_idl_7.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // Tests an invalid IDL file.

	6

	7 namespace test {

	8 /* Unexpected symbol DOMString afte symbol a. */
	not at google - send to devlin 2013/09/09 16:14:07 s/afte/after/ s/afte/after/ Haojian Wu 2013/09/10 02:51:04 Done. Show quoted text On 2013/09/09 16:14:07, kalman wrote: > s/afte/after/ Done.
	9 dictionary MissingSemicolon {

	10 DOMString a

	11 DOMString b;

	12 };

	13 };

	14
	not at google - send to devlin 2013/09/09 16:14:07 no \n no \n Haojian Wu 2013/09/10 02:51:04 Done. Show quoted text On 2013/09/09 16:14:07, kalman wrote: > no \n Done.
OLD	NEW