Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3919)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_types.h

Issue 23512003: new animation for rAc card generation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix unit tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_types.h
diff --git a/chrome/browser/ui/autofill/autofill_dialog_types.h b/chrome/browser/ui/autofill/autofill_dialog_types.h
index 459008b0719e08c9176e5efe9f2bd98b72029c28..788c44da42ac0709d8cbdfd7731daf9f4d0eefdd 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_types.h
+++ b/chrome/browser/ui/autofill/autofill_dialog_types.h
@@ -10,6 +10,7 @@
#include "base/callback_forward.h"
#include "base/strings/string16.h"
+#include "base/time/time.h"
#include "components/autofill/core/browser/autofill_metrics.h"
#include "components/autofill/core/browser/field_types.h"
#include "third_party/skia/include/core/SkColor.h"
@@ -187,10 +188,11 @@ struct SuggestionState {
struct DialogOverlayString {
DialogOverlayString();
~DialogOverlayString();
- // TODO(estade): need to set a color as well.
base::string16 text;
+ // TODO(estade): should be able to remove this; text is always black.
SkColor text_color;
gfx::Font font;
+ // TODO(estade): should be able to remove this; text is always centered.
gfx::HorizontalAlignment alignment;
};
@@ -203,9 +205,12 @@ struct DialogOverlayState {
// more or less front and center.
gfx::Image image;
// If non-empty, messages to display.
+ // TODO(estade): make this a single string, no longer need to support multiple
+ // messages.
std::vector<DialogOverlayString> strings;
- // If non-empty, holds text that should go on a button.
- base::string16 button_text;
+ // The amount of time this dialog is valid for. After this time has elapsed,
+ // the view should update the overlay.
+ base::TimeDelta expiry;
};
enum ValidationType {

Powered by Google App Engine
This is Rietveld 408576698