Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 23510010: [rac] Show amex-specific cvc hint for saved autofill card (Closed)

Created:
7 years, 3 months ago by please use gerrit instead
Modified:
7 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rac] Show amex-specific cvc hint for saved autofill card This patch uses the amex-specific cvc icon for saved autofill card. Autofill card stores and returns the credit card type in human-readable format (eg "Visa"), but AutofillDailogControllerImpl expected a WebKit-readable string instead (eg "visaCC"). This discrepancy caused the autofill dialog to show a generic cvc icon for a saved amex card. This patch changes WalletItems to return human-readable credit card types to match Autofill. The patch also changes AutofillDailogControllerImpl to check for human-readable format instead of the Webkit-readable format. As a result, the saved autofill card now displays the amex-specific cvc icon for a saved amex card. Manual tests: 1) Save two cards in autofill: amex and visa. 2) Invoke rac dialog and switch to autofill mode. 3) Switch to saved amex card: cvc icon should be amex-specific. 4) Switch to saved visa card: cvc icon should be generic. This patch depends on http://codereview.chromium.org/23756007. BUG=250853 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -30 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_items.cc View 3 chunks +11 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Evan: PTAL.
7 years, 3 months ago (2013-09-18 18:44:32 UTC) #1
Evan Stade
lgtm
7 years, 3 months ago (2013-09-18 21:27:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/23510010/1
7 years, 3 months ago (2013-09-18 21:29:41 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-19 00:42:10 UTC) #4
Message was sent while issue was closed.
Change committed as 223999

Powered by Google App Engine
This is Rietveld 408576698