Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/test/perf/perf_test.h

Issue 23509002: Factor out a perf test result printer method. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix mac compile Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/perf/memory_test.cc ('k') | chrome/test/perf/perf_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/perf/perf_test.h
diff --git a/chrome/test/perf/perf_test.h b/chrome/test/perf/perf_test.h
index c40cc5ec9c1eea1653c39c6329acd1863cf31fa8..f41558ac94bd90bc06840695960e20485ae097e6 100644
--- a/chrome/test/perf/perf_test.h
+++ b/chrome/test/perf/perf_test.h
@@ -12,88 +12,6 @@
namespace perf_test {
-// Prints numerical information to stdout in a controlled format, for
-// post-processing. |measurement| is a description of the quantity being
-// measured, e.g. "vm_peak"; |modifier| is provided as a convenience and
-// will be appended directly to the name of the |measurement|, e.g.
-// "_browser"; |trace| is a description of the particular data point, e.g.
-// "reference"; |value| is the measured value; and |units| is a description
-// of the units of measure, e.g. "bytes". If |important| is true, the output
-// line will be specially marked, to notify the post-processor. The strings
-// may be empty. They should not contain any colons (:) or equals signs (=).
-// A typical post-processing step would be to produce graphs of the data
-// produced for various builds, using the combined |measurement| + |modifier|
-// string to specify a particular graph and the |trace| to identify a trace
-// (i.e., data series) on that graph.
-void PrintResult(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- size_t value,
- const std::string& units,
- bool important);
-
-void AppendResult(std::string& output,
- const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- size_t value,
- const std::string& units,
- bool important);
-
-// Like the above version of PrintResult(), but takes a std::string value
-// instead of a size_t.
-void PrintResult(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& value,
- const std::string& units,
- bool important);
-
-void AppendResult(std::string& output,
- const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& value,
- const std::string& units,
- bool important);
-
-// Like PrintResult(), but prints a (mean, standard deviation) result pair.
-// The |<values>| should be two comma-separated numbers, the mean and
-// standard deviation (or other error metric) of the measurement.
-void PrintResultMeanAndError(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& mean_and_error,
- const std::string& units,
- bool important);
-
-void AppendResultMeanAndError(std::string& output,
- const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& mean_and_error,
- const std::string& units,
- bool important);
-
-// Like PrintResult(), but prints an entire list of results. The |values|
-// will generally be a list of comma-separated numbers. A typical
-// post-processing step might produce plots of their mean and standard
-// deviation.
-void PrintResultList(const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& values,
- const std::string& units,
- bool important);
-
-void AppendResultList(std::string& output,
- const std::string& measurement,
- const std::string& modifier,
- const std::string& trace,
- const std::string& values,
- const std::string& units,
- bool important);
-
// Prints IO performance data for use by perf graphs.
void PrintIOPerfInfo(const std::string& test_name,
const ChromeProcessList& chrome_processes,
@@ -122,20 +40,6 @@ std::string MemoryUsageInfoToString(const std::string& test_name,
const ChromeProcessList& chrome_processes,
base::ProcessId browser_pid);
-// Prints memory commit charge stats for use by perf graphs.
-void PrintSystemCommitCharge(const std::string& test_name,
- size_t charge,
- bool important);
-
-void PrintSystemCommitCharge(FILE* target,
- const std::string& test_name,
- size_t charge,
- bool important);
-
-std::string SystemCommitChargeToString(const std::string& test_name,
- size_t charge,
- bool important);
-
} // namespace perf_test
#endif // CHROME_TEST_PERF_PERF_TEST_H_
« no previous file with comments | « chrome/test/perf/memory_test.cc ('k') | chrome/test/perf/perf_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698