Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: tools/metrics/actions/extract_actions.py

Issue 23508003: Added UMA actions to devices page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/metrics/actions/chromeactions.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/actions/extract_actions.py
diff --git a/tools/metrics/actions/extract_actions.py b/tools/metrics/actions/extract_actions.py
index f6819afdd05aa61a4518c95bc2d573f22b1c897a..250b8847d47047340da0b270050e2fe5d3c489d4 100755
--- a/tools/metrics/actions/extract_actions.py
+++ b/tools/metrics/actions/extract_actions.py
@@ -545,6 +545,20 @@ def AddHistoryPageActions(actions):
actions.add('HistoryPage_ConfirmRemoveSelected')
actions.add('HistoryPage_CancelRemoveSelected')
+def AddDevicesPageActions(actions):
+ """Add actions that are used in Devices page.
+
+ Arguments
+ actions: set of actions to add to.
+ """
+ actions.add('DevicesPage_Opened')
+ actions.add('DevicesPage_AddPrintersClicked')
+ actions.add('DevicesPage_RegisterClicked')
+ actions.add('DevicesPage_RegisterCancel')
+ actions.add('DevicesPage_RegisterFailure')
+ actions.add('DevicesPage_RegisterSuccess')
+ actions.add('DevicesPage_ManageClicked')
+
def main(argv):
if '--hash' in argv:
hash_output = True
@@ -585,6 +599,7 @@ def main(argv):
AddAndroidActions(actions)
AddBookmarkManagerActions(actions)
AddHistoryPageActions(actions)
+ AddDevicesPageActions(actions)
Ilya Sherman 2013/09/06 00:53:32 nit: While you're here, let's alphabetize these ca
Vitaly Buka (NO REVIEWS) 2013/09/06 06:21:09 I'll enable CQ now as-is and if it's committed by
Noam Samuel 2013/09/06 22:03:58 Done.
if hash_output:
f = open(chromeactions_path, "wb")
« no previous file with comments | « tools/metrics/actions/chromeactions.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698