Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: tools/perf/metrics/gpu_rendering_stats.py

Issue 23506030: telemetry: Add new metrics to smoothness benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/metrics/discrepancy_unittest.py ('k') | tools/perf/metrics/smoothness.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/gpu_rendering_stats.py
diff --git a/tools/perf/metrics/gpu_rendering_stats.py b/tools/perf/metrics/gpu_rendering_stats.py
index 12ac37d03ba9aaf70ade620c528ed91cb07585b1..d73da12cad47b5bec62bfc3c9e1e32ec9aa11a51 100644
--- a/tools/perf/metrics/gpu_rendering_stats.py
+++ b/tools/perf/metrics/gpu_rendering_stats.py
@@ -23,6 +23,7 @@ class GpuRenderingStats(object):
self.total_time = (self.end - self.start) / 1000.0
self.animation_frame_count = []
self.screen_frame_count = []
+ self.screen_frame_timestamps = []
self.paint_time = []
self.record_time = []
self.commit_time = []
@@ -90,10 +91,15 @@ class GpuRenderingStats(object):
if event.start >= self.start and event.end <= self.end:
if 'data' not in event.args:
continue
+ if event.args['data']['screen_frame_count'] > 1:
+ raise ValueError, 'trace contains multi-frame render stats'
self.animation_frame_count.append(
event.args['data']['animation_frame_count'])
self.screen_frame_count.append(
event.args['data']['screen_frame_count'])
+ if event.args['data']['screen_frame_count'] == 1:
+ self.screen_frame_timestamps.append(
+ event.start)
self.paint_time.append(
event.args['data']['paint_time'])
self.record_time.append(
@@ -117,8 +123,13 @@ class GpuRenderingStats(object):
if event.start >= self.start and event.end <= self.end:
if 'data' not in event.args:
continue
+ if event.args['data']['screen_frame_count'] > 1:
+ raise ValueError, 'trace contains multi-frame render stats'
self.screen_frame_count.append(
event.args['data']['screen_frame_count'])
+ if event.args['data']['screen_frame_count'] == 1:
+ self.screen_frame_timestamps.append(
+ event.start)
self.dropped_frame_count.append(
event.args['data']['dropped_frame_count'])
self.rasterize_time.append(
« no previous file with comments | « tools/perf/metrics/discrepancy_unittest.py ('k') | tools/perf/metrics/smoothness.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698