Issue 23506029: Enabling the new drag off shellf feature by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23506029: Enabling the new drag off shellf feature by default (Closed)

Created:
7 years, 3 months ago by Mr4D (OOO till 08-26)

Modified:
7 years, 3 months ago

Reviewers:
James Cook

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enabling the new drag off shellf feature by default BUG=284772 TEST=unittest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221298

Patch Set 1 #

Patch Set 2 : Fixed unittest #

Patch Set 3 : Removed unnecessary log statement #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -13 lines)			Patch
M	ash/ash_switches.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	ash/ash_switches.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	ash/launcher/launcher_view_unittest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/23506029/1

7 years, 3 months ago (2013-09-03 23:13:22 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=151095

7 years, 3 months ago (2013-09-04 00:59:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/23506029/8001

7 years, 3 months ago (2013-09-04 16:33:44 UTC) #5

Message was sent while issue was closed.

Change committed as 221298

Expand Messages | Collapse Messages