Chromium Code Reviews Chromium Code Reviews
Issue
23506027:
Implement web content hit testing in win aura. (Closed)
DescriptionImplement web content hit testing in win aura.
NativeViewAccessibilityWin needs to do hit testing in
web content as well as views. While implementing this,
I realized that it isn't necessary to have a special
interface to a RWHV to get an object by child id - we
can just rely on WebView overriding
GetNativeViewAccessible and do the lookup using a
native call.
The same trick works for hit testing - we check if
the point is inside a child's bounding rect, and if so
we call accHitTest on that child's native view
accessible - and since WebView overrides
GetNativeViewAccessible, the recursive call to
accHitTest will return the correct result from inside
the web content.
We still need AccessibleWebViewRegistry (because
looking up objects from child ids gets called A LOT,
but it's much simpler now, just a set of Views.
BUG=284803
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221744
Patch Set 1 #Patch Set 2 : Better logic #
Total comments: 10
Patch Set 3 : Address feedback #Patch Set 4 : Fix compile error #Messages
Total messages: 11 (0 generated)
|
