Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: android_webview/android_webview.gyp

Issue 23506016: Android WebView: re-enable linker warnings where possible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2009 The Chromium Authors. All rights reserved. 1 # Copyright 2009 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 'chromium_code': 1, 6 'chromium_code': 1,
7 }, 7 },
8 'includes': [ 8 'includes': [
9 'android_webview_tests.gypi', 9 'android_webview_tests.gypi',
10 ], 10 ],
11 'targets': [ 11 'targets': [
12 { 12 {
13 'target_name': 'libwebviewchromium', 13 'target_name': 'libwebviewchromium',
14 'type': 'shared_library', 14 'type': 'shared_library',
15 'android_unmangled_name': 1, 15 'android_unmangled_name': 1,
16 'dependencies': [ 16 'dependencies': [
17 'android_webview_common', 17 'android_webview_common',
18 ], 18 ],
19 'conditions': [ 19 'conditions': [
20 # The general approach is to allow the executable target to choose 20 # The general approach is to allow the executable target to choose
21 # the allocator, but as in the WebView case we are building a library 21 # the allocator, but as in the WebView case we are building a library
22 # only, put the dependency on the allocator here 22 # only, put the dependency on the allocator here
23 [ 'android_webview_build==1 and android_use_tcmalloc==1', { 23 [ 'android_webview_build==1 and android_use_tcmalloc==1', {
24 'dependencies': [ 24 'dependencies': [
25 '../base/allocator/allocator.gyp:allocator', ], 25 '../base/allocator/allocator.gyp:allocator', ],
26 }], 26 }],
27 ], 27 [ 'android_webview_build==1 and use_system_skia==0', {
28 'ldflags': [ 28 # When not using the system skia there are linker warnings about
29 # fix linking to hidden symbols and re-enable this (crbug.com/157326) 29 # overriden hidden symbols which there's no easy way to eliminate;
30 '-Wl,--no-fatal-warnings' 30 # disable them. http://crbug.com/157326
31 'ldflags': [
32 '-Wl,--no-fatal-warnings',
33 ],
34 'ldflags!': [
35 '-Wl,--fatal-warnings',
36 ],
37 }],
31 ], 38 ],
32 'sources': [ 39 'sources': [
33 'lib/main/webview_entry_point.cc', 40 'lib/main/webview_entry_point.cc',
34 ], 41 ],
35 }, 42 },
36 { 43 {
37 'target_name': 'android_webview_pak', 44 'target_name': 'android_webview_pak',
38 'type': 'none', 45 'type': 'none',
39 'dependencies': [ 46 'dependencies': [
40 '<(DEPTH)/content/content_resources.gyp:content_resources', 47 '<(DEPTH)/content/content_resources.gyp:content_resources',
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 '../content/content.gyp:content_java', 205 '../content/content.gyp:content_java',
199 '../ui/ui.gyp:ui_java', 206 '../ui/ui.gyp:ui_java',
200 ], 207 ],
201 'variables': { 208 'variables': {
202 'java_in_dir': '../android_webview/java', 209 'java_in_dir': '../android_webview/java',
203 }, 210 },
204 'includes': [ '../build/java.gypi' ], 211 'includes': [ '../build/java.gypi' ],
205 }, 212 },
206 ], 213 ],
207 } 214 }
OLDNEW
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698