Issue 23506016: Android WebView: re-enable linker warnings where possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23506016: Android WebView: re-enable linker warnings where possible. (Closed)

Created:
7 years, 3 months ago by Torne

Modified:
7 years, 3 months ago

Reviewers:
benm (inactive), Ben Murdoch

CC:
chromium-reviews, android-webview-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Android WebView: re-enable linker warnings where possible. Re-enable linker warnings being treated as errors when using the system version of skia, since there are no more warnings in this configuration. Also, fix the global disabling of linker warnings (introduced to fix mac builds) to only apply to host targets. BUG=157326 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220873

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -20 lines)			Patch
	M	android_webview/android_webview.gyp	View		1 chunk	+11 lines, -4 lines	0 comments	Download
	M	build/common.gypi	View		3 chunks	+2 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/23506016/1

7 years, 3 months ago (2013-09-02 14:50:27 UTC) #3

Message was sent while issue was closed.

Change committed as 220873

Expand Messages | Collapse Messages