Issue 23506003: [Android] Add a cleanup option to generate_emma_html.py.

Issue 23506003: [Android] Add a cleanup option to generate_emma_html.py. (Closed)

Created:
7 years, 3 months ago by frankf

Modified:
7 years, 3 months ago

Reviewers:
craigdh

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Add a cleanup option to generate_emma_html.py. This gets rid of any old *.em/*.ec files. BUG=278365 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219839

Patch Set 2 : nit fixed #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -7 lines)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		2 chunks	+1 line, -3 lines	0 comments	Download
	M	build/android/generate_emma_html.py	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

craigdh

lgtm w/ nit. https://codereview.chromium.org/23506003/diff/9001/build/android/generate_emma_html.py File build/android/generate_emma_html.py (right): https://codereview.chromium.org/23506003/diff/9001/build/android/generate_emma_html.py#newcode53 build/android/generate_emma_html.py:53: option_parser.error('One ore more mandatory options are ...

7 years, 3 months ago (2013-08-27 21:21:36 UTC) #2

frankf

https://codereview.chromium.org/23506003/diff/9001/build/android/generate_emma_html.py File build/android/generate_emma_html.py (right): https://codereview.chromium.org/23506003/diff/9001/build/android/generate_emma_html.py#newcode53 build/android/generate_emma_html.py:53: option_parser.error('One ore more mandatory options are missing.') On 2013/08/27 ...

7 years, 3 months ago (2013-08-27 21:23:05 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/frankf@chromium.org/23506003/17001

7 years, 3 months ago (2013-08-27 21:58:32 UTC) #4

Message was sent while issue was closed.

Change committed as 219839

Expand Messages | Collapse Messages