Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2350363005: [test] call willSendRequest in dispatchWillSendRequest
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index 844e2cf16688bfecc961441546df83b252047f3b..8e48699af8a62a30e6aee11f948057cffa573294 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -6026,9 +6026,9 @@ TEST_P(ParameterizedWebFrameTest, NavigateToSameNoConditionalRequestForSubresour
WebCache::clear();
FrameTestHelpers::loadFrame(webViewHelper.webView()->mainFrame(), m_baseURL + "foo_with_image.html");
- // 2 images are requested, and each triggers 2 willSendRequest() calls,
- // once for preloading and once for the real request.
- EXPECT_EQ(client.numOfImageRequests(), 4);
+ // 2 images are requested, and each triggers 1 willSendRequest() calls for
+ // the preload. The real requests are served from MemoryCache.
+ EXPECT_EQ(client.numOfImageRequests(), 2);
}
TEST_P(ParameterizedWebFrameTest, WebNodeImageContents)
« no previous file with comments | « third_party/WebKit/Source/core/loader/FrameFetchContext.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698