Fix memory leak in app_controller_mac.mm.

chrome/browser/app_controller_mac.mm

Index: chrome/browser/app_controller_mac.mm
===================================================================
--- chrome/browser/app_controller_mac.mm	(revision 222257)
+++ chrome/browser/app_controller_mac.mm	(working copy)
@@ -169,12 +169,13 @@
   // or a unit test.)
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
 
-  base::FilePath appBundlePath =
+  base::FilePath app_bundle_path =
       chrome::GetVersionedDirectory().DirName().DirName().DirName();
+  base::ScopedCFTypeRef<CFStringRef> app_bundle_path_cfstring(
+      base::SysUTF8ToCFStringRef(app_bundle_path.value()));

[Nico, 2013/09/16 21:05:28]

This on the other hand is just surprising API. Every time we fix one of these I
look at all callers of this function.

[Alexei Svitkine (slow), 2013/09/16 21:07:25]

Yeah, we should rename the API.

   CFPreferencesSetAppValue(
       base::mac::NSToCFCast(app_mode::kLastRunAppBundlePathPrefsKey),
-      base::SysUTF8ToCFStringRef(appBundlePath.value()),
-      BaseBundleID_CFString());
+      app_bundle_path_cfstring, BaseBundleID_CFString());
 
   // Sync after a delay avoid I/O contention on startup; 1500 ms is plenty.
   BrowserThread::PostDelayedTask(