Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 23503040: Remove all NetworkLibrary dependencies from AutomationTestingProvider (Closed)

Created:
7 years, 3 months ago by stevenjb
Modified:
7 years, 3 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dyu1, anantha, robertshield, oshima+watch_chromium.org, dennis_jeffrey, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove all NetworkLibrary dependencies from AutomationTestingProvider BUG=259896 TBR=phajdan.jr@chromium.org, achuith@chromium.org for c/b/automation Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222379

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -995 lines) Patch
M chrome/browser/automation/automation_provider.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 5 chunks +1 line, -17 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 2 3 chunks +0 lines, -165 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers_chromeos.cc View 3 chunks +0 lines, -244 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.h View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 5 chunks +0 lines, -301 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 4 chunks +1 line, -14 lines 0 comments Download
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/functional/chromeos_wifi_sanity.py View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/test/pyautolib/chromeos_network.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyauto.py View 2 chunks +0 lines, -164 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
stevenjb
This is the of AutomationTestingProvider half https://codereview.chromium.org/23618026/ (I broke this up to make the review ...
7 years, 3 months ago (2013-09-06 22:48:42 UTC) #1
gauravsh
lgtm
7 years, 3 months ago (2013-09-07 17:12:41 UTC) #2
pneubeck (no reviews)
lgtm
7 years, 3 months ago (2013-09-10 14:25:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/23503040/11001
7 years, 3 months ago (2013-09-10 18:31:58 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=24731
7 years, 3 months ago (2013-09-10 18:54:14 UTC) #5
stevenjb
I'm going to go ahead and push this now, even though the Telemetry test is ...
7 years, 3 months ago (2013-09-10 19:23:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/23503040/11001
7 years, 3 months ago (2013-09-10 19:33:37 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 23:00:23 UTC) #8
Message was sent while issue was closed.
Change committed as 222379

Powered by Google App Engine
This is Rietveld 408576698