Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 23503023: Reland after fix: Improve <webview> autosize: (Closed)

Created:
7 years, 3 months ago by lazyboy
Modified:
7 years, 3 months ago
Reviewers:
Fady Samuel, sadrul
CC:
chromium-reviews, joi+watch-content_chromium.org, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reland after fix: Improve <webview> autosize: a. Expand/shrink <webview> element when 'sizechange' event fires, to match with the new view size (in shim). b. For SW mode, fix a bug where damage buffer would remain smaller than the view size and would result in crash. Added test for this case. BUG=173238, 282116 Test=WebViewTest.AutoSize.*, <webview>.autosize=true now should autosize webview container within the constraints (minwidth/maxwidth/minheight/maxheight). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221023

Patch Set 1 #

Patch Set 2 : Fixes for re-land. #

Total comments: 2

Patch Set 3 : Address comments from sadrul@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -63 lines) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 2 4 chunks +27 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 1 3 chunks +73 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/autosize/main.html View 2 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/data/extensions/platform_apps/web_view/autosize/main.js View 1 chunk +63 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/autosize/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/autosize/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 2 1 chunk +10 lines, -16 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 2 chunks +10 lines, -6 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 13 chunks +61 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
lazyboy
Ran 200 times on Mac this time, also a trick to expose the race the ...
7 years, 3 months ago (2013-08-31 01:27:00 UTC) #1
lazyboy
+sadrul as fady is in vacation.
7 years, 3 months ago (2013-09-03 18:03:51 UTC) #2
sadrul
A small nit, otherwise lgtm https://chromiumcodereview.appspot.com/23503023/diff/3001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js File chrome/test/data/extensions/platform_apps/web_view/shim/main.js (right): https://chromiumcodereview.appspot.com/23503023/diff/3001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js#newcode186 chrome/test/data/extensions/platform_apps/web_view/shim/main.js:186: embedder.test.assertTrue(e.newWidth <= 700); can ...
7 years, 3 months ago (2013-09-03 18:04:20 UTC) #3
Fady Samuel
lgtm
7 years, 3 months ago (2013-09-03 18:05:35 UTC) #4
lazyboy
https://chromiumcodereview.appspot.com/23503023/diff/3001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js File chrome/test/data/extensions/platform_apps/web_view/shim/main.js (right): https://chromiumcodereview.appspot.com/23503023/diff/3001/chrome/test/data/extensions/platform_apps/web_view/shim/main.js#newcode186 chrome/test/data/extensions/platform_apps/web_view/shim/main.js:186: embedder.test.assertTrue(e.newWidth <= 700); On 2013/09/03 18:04:20, sadrul wrote: > ...
7 years, 3 months ago (2013-09-03 18:47:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/23503023/21001
7 years, 3 months ago (2013-09-03 18:48:52 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 21:12:13 UTC) #7
Message was sent while issue was closed.
Change committed as 221023

Powered by Google App Engine
This is Rietveld 408576698