Issue 23503016: Cleanup: Remove the WebCryptoAlgorithm::name() attribute.

Issue 23503016: Cleanup: Remove the WebCryptoAlgorithm::name() attribute. (Closed)

Created:
7 years, 3 months ago by eroman

Modified:
7 years, 3 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, jamesr, eae+blinkwatch, dglazkov+blink, abarth-chromium, tommyw+watchlist_chromium.org, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Cleanup: Remove the WebCryptoAlgorithm::name() attribute. This wasn't needed on the embedder's side so may as well remove it from the public API and save a word. (it was also awkward having to pass this in when constructing a WebCryptoAlgorithm) BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157016

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename get() --> instance() #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -22 lines)			Patch
M	Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp	View		1 chunk	+9 lines, -11 lines	0 comments	Download
M	Source/modules/crypto/Algorithm.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/modules/crypto/NormalizeAlgorithm.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	Source/modules/crypto/NormalizeAlgorithm.cpp	View	1	5 chunks	+25 lines, -7 lines	0 comments	Download
M	public/platform/WebCryptoAlgorithm.h	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/23503016/diff/1/Source/modules/crypto/NormalizeAlgorithm.cpp File Source/modules/crypto/NormalizeAlgorithm.cpp (right): https://codereview.chromium.org/23503016/diff/1/Source/modules/crypto/NormalizeAlgorithm.cpp#newcode143 Source/modules/crypto/NormalizeAlgorithm.cpp:143: const AlgorithmRegistry* AlgorithmRegistry::get() We'll often call these functions ...

7 years, 3 months ago (2013-08-30 07:14:09 UTC) #2

eroman

https://codereview.chromium.org/23503016/diff/1/Source/modules/crypto/NormalizeAlgorithm.cpp File Source/modules/crypto/NormalizeAlgorithm.cpp (right): https://codereview.chromium.org/23503016/diff/1/Source/modules/crypto/NormalizeAlgorithm.cpp#newcode143 Source/modules/crypto/NormalizeAlgorithm.cpp:143: const AlgorithmRegistry* AlgorithmRegistry::get() On 2013/08/30 07:14:09, abarth wrote: > ...

7 years, 3 months ago (2013-08-30 17:50:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23503016/8001

7 years, 3 months ago (2013-08-30 17:51:08 UTC) #4

Message was sent while issue was closed.

Change committed as 157016

Expand Messages | Collapse Messages