Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 23502003: Make InputType and InputTypeView RefCounted. (Closed)

Created:
7 years, 3 months ago by tkent
Modified:
7 years, 3 months ago
Reviewers:
keishi, esprehn
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Make InputType and InputTypeView RefCounted. This is a preparation to add HTMLInputElement::m_inputTypeView. Both of m_inputType and m_inputTypeView will be able to own single InputType object. BUG=274205 TEST=none; no behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156800

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -74 lines) Patch
M Source/core/html/ButtonInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ButtonInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/CheckboxInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/CheckboxInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/ColorInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ColorInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/DateInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/DateTimeLocalInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DateTimeLocalInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/EmailInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/EmailInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/FileInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FileInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLInputElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HiddenInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HiddenInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/ImageInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/InputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/InputType.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/MonthInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MonthInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/NumberInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/NumberInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/PasswordInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/PasswordInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/RadioInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/RangeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RangeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/ResetInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ResetInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/SearchInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/SearchInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/SubmitInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/SubmitInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TelephoneInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TelephoneInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TextInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TextInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/TimeInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/TimeInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/URLInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/URLInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/WeekInputType.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/WeekInputType.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/forms/InputTypeView.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
tkent
7 years, 3 months ago (2013-08-27 01:59:22 UTC) #1
esprehn
What's the benefit of them being RefCounted? This makes all InputTypes larger.
7 years, 3 months ago (2013-08-27 02:26:25 UTC) #2
tkent
On 2013/08/27 02:26:25, esprehn wrote: > What's the benefit of them being RefCounted? This makes ...
7 years, 3 months ago (2013-08-27 03:24:30 UTC) #3
keishi
lgtm
7 years, 3 months ago (2013-08-27 16:39:09 UTC) #4
esprehn_google.com
Lgtm On Tuesday, August 27, 2013, wrote: > lgtm > > > > https://codereview.chromium.**org/23502003/<https://codereview.chromium.org/23502003/> > ...
7 years, 3 months ago (2013-08-27 17:01:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23502003/1
7 years, 3 months ago (2013-08-27 23:42:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/23502003/1
7 years, 3 months ago (2013-08-28 00:01:16 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-08-28 00:17:53 UTC) #8
Message was sent while issue was closed.
Change committed as 156800

Powered by Google App Engine
This is Rietveld 408576698