Removes uses of unnamed namespace from samplecode.

Removes uses of unnamed namespace from samplecode.

Skia code prefers static over unnamed namespace.

R=bsalomon@google.com,robertphillips@google.com

Committed: http://code.google.com/p/skia/source/detail?r=11248

[tfarina, 2013-09-10 00:10:18]

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp
File samplecode/OverView.cpp (right):

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp#newco...
samplecode/OverView.cpp:18: const char gIsOverview[] = "is-overview";
$ nm out/Debug/obj/samplecode/SampleApp.OverView.o | c++filt

0000000000000000 r gIsOverview

The others don't appear.

Is there another way to tell if the symbol is public or private?

[tfarina, 2013-09-10 18:14:07]

ping? this is ready for review.

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp
File samplecode/OverView.cpp (right):

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp#newco...
samplecode/OverView.cpp:15: const int N = 8;
AFAIK, const has internal linkage in C++.

[bsalomon, 2013-09-11 20:15:27]

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp
File samplecode/OverView.cpp (right):

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp#newco...
samplecode/OverView.cpp:18: const char gIsOverview[] = "is-overview";
On 2013/09/10 00:10:18, tfarina wrote:
> $ nm out/Debug/obj/samplecode/SampleApp.OverView.o | c++filt
> 
> 0000000000000000 r gIsOverview
> 
> The others don't appear.
> 
> Is there another way to tell if the symbol is public or private?

Is that gIsOverview is treated as a ptr to a const char array and so the ptr
itself has external linkage while the thing it points to does not?

In any event, I would suggest explicitly making these static even if it is just
for documentation for the reader.

[bsalomon, 2013-09-11 21:10:28]

lgtm

[commit-bot: I haz the power, 2013-09-11 21:10:37]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/23498028/7001

[tfarina, 2013-09-11 21:15:20]

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp
File samplecode/OverView.cpp (right):

https://codereview.chromium.org/23498028/diff/1/samplecode/OverView.cpp#newco...
samplecode/OverView.cpp:18: const char gIsOverview[] = "is-overview";
On 2013/09/11 20:15:27, bsalomon wrote:
> On 2013/09/10 00:10:18, tfarina wrote:
> > $ nm out/Debug/obj/samplecode/SampleApp.OverView.o | c++filt
> > 
> > 0000000000000000 r gIsOverview
> > 
> > The others don't appear.
> > 
> > Is there another way to tell if the symbol is public or private?
> 
> Is that gIsOverview is treated as a ptr to a const char array and so the ptr
> itself has external linkage while the thing it points to does not?
>
no.

according to cdecl and the right-to-left syntax of C, this reads as:

gIsOverview is an array to const char.

if it was:

const char* gIsOverview = "...";

then that would be translated as:
gIsOverview is a pointer to const char.

No it doesn't have external linkage:

$ nm -g out/Debug/obj/samplecode/SampleApp.OverView.o | c++filt | grep
gIsOverview

-g means "Display only external symbols".

r means the symbol is in a read only data section.

> In any event, I would suggest explicitly making these static even if it is
just
> for documentation for the reader.
> 
Done.

[commit-bot: I haz the power, 2013-09-13 12:39:59]

Change committed as 11248