Issue 23496039: DevTools: [CodeMirror] roll CodeMirror to @e0b0e32ed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23496039: DevTools: [CodeMirror] roll CodeMirror to @e0b0e32ed (Closed)

Created:
7 years, 3 months ago by lushnikov

Modified:
7 years, 3 months ago

Reviewers:
vsevik, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: [CodeMirror] roll CodeMirror to @e0b0e32ed This patch rolls CodeMirror to @e0b0e32ed. This time we do not patch CodeMirror to bring support for the long lines: instead, we rely on its core functionality as it was recently improved. Experiments proved it to be decent. TBR=vsevik, pfeldman BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157456

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -109 lines)			Patch
M	Source/devtools/front_end/CodeMirrorTextEditor.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/devtools/front_end/cm/codemirror.css	View	5 chunks	+8 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/cm/codemirror.js	View	43 chunks	+139 lines, -106 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/23496039/1

7 years, 3 months ago (2013-09-09 14:11:50 UTC) #1

Message was sent while issue was closed.

Change committed as 157456

Expand Messages | Collapse Messages