Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 23495008: Added viewport tests for missing/empty content attribute. (Closed)

Created:
7 years, 3 months ago by rune
Modified:
7 years, 3 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, johnme, aelias_OOO_until_Jul13
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Added viewport tests for missing/empty content attribute. For <meta name="viewport" ... >: - content="" overrides previous meta viewport using the 980px fallback width. - content without a value is a no-op. - missing content attribute is a no-op. Added tests to detect future regressions. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156857

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A + LayoutTests/fast/viewport/viewport-135.html View 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/fast/viewport/viewport-135-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/viewport/viewport-136.html View 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/fast/viewport/viewport-136-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/viewport/viewport-137.html View 1 chunk +2 lines, -1 line 0 comments Download
A + LayoutTests/fast/viewport/viewport-137-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rune
7 years, 3 months ago (2013-08-28 14:33:21 UTC) #1
Mike West
On 2013/08/28 14:33:21, rune wrote: These are new tests, right? The diff view doesn't make ...
7 years, 3 months ago (2013-08-28 14:37:59 UTC) #2
rune
On 2013/08/28 14:37:59, Mike West wrote: > On 2013/08/28 14:33:21, rune wrote: > > These ...
7 years, 3 months ago (2013-08-28 14:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/23495008/1
7 years, 3 months ago (2013-08-28 14:40:32 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-28 16:30:47 UTC) #5
Message was sent while issue was closed.
Change committed as 156857

Powered by Google App Engine
This is Rietveld 408576698