Issue 23494037: Use x32 icon asset for App List Webstore search rather than rescaling x128 to x32 each time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23494037: Use x32 icon asset for App List Webstore search rather than rescaling x128 to x32 each time. (Closed)

Created:
7 years, 3 months ago by tapted

Modified:
7 years, 3 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use x32 icon asset for App List Webstore search rather than rescaling x128 to x32 each time. Both OSX and Views' App List implemetnations use a kIconDimension of 32x32 for icons shown in search results. This change uses a prescaled 32x32 icon asset for attaching to the "Search in webstore" result type, rather than rescaling a 128x128 icon asset to 32x32 each time it is shown. BUG=285735 TEST=On OSX, perform a search in the app launcher that shows a webstore search option - it should show the webstore icon next to it. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222116

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/app_list/search/search_webstore_result.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/23494037/1

7 years, 3 months ago (2013-09-09 18:39:30 UTC) #3

Message was sent while issue was closed.

Change committed as 222116

Expand Messages | Collapse Messages