Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc

Issue 23494028: Do not return FileSystem contents if the profile is in incognito mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc
diff --git a/webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc b/webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc
index 8f39b2dd9d81736cf79cea09d2b55a4bd1d759a1..89d4ebd62fe9b3cadb25d23e541ee0c6097eba94 100644
--- a/webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc
+++ b/webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc
@@ -78,12 +78,13 @@ class FileSystemDirURLRequestJobTest : public testing::Test {
ASSERT_EQ(base::PLATFORM_FILE_OK, result);
}
- void TestRequestHelper(const GURL& url, bool run_to_completion) {
+ void TestRequestHelper(const GURL& url, bool run_to_completion,
+ FileSystemContext* file_system_context) {
delegate_.reset(new net::TestDelegate());
delegate_->set_quit_on_redirect(true);
request_.reset(empty_context_.CreateRequest(url, delegate_.get()));
job_ = new FileSystemDirURLRequestJob(
- request_.get(), NULL, file_system_context_.get());
+ request_.get(), NULL, file_system_context);
request_->Start();
ASSERT_TRUE(request_->is_pending()); // verify that we're starting async
@@ -92,11 +93,16 @@ class FileSystemDirURLRequestJobTest : public testing::Test {
}
void TestRequest(const GURL& url) {
- TestRequestHelper(url, true);
+ TestRequestHelper(url, true, file_system_context_.get());
+ }
+
+ void TestRequestWithContext(const GURL& url,
+ FileSystemContext* file_system_context) {
+ TestRequestHelper(url, true, file_system_context);
}
void TestRequestNoRun(const GURL& url) {
- TestRequestHelper(url, false);
+ TestRequestHelper(url, false, file_system_context_.get());
}
FileSystemURL CreateURL(const base::FilePath& file_path) {
@@ -286,5 +292,28 @@ TEST_F(FileSystemDirURLRequestJobTest, Cancel) {
// If we get here, success! we didn't crash!
}
+TEST_F(FileSystemDirURLRequestJobTest, Incognito) {
+ CreateDirectory("foo");
+
+ scoped_refptr<FileSystemContext> file_system_context =
+ CreateIncognitoFileSystemContextForTesting(NULL, temp_dir_.path());
+
+ TestRequestWithContext(CreateFileSystemURL("/"),
+ file_system_context.get());
+ ASSERT_FALSE(request_->is_pending());
+ ASSERT_TRUE(request_->status().is_success());
+
+ std::istringstream in(delegate_->data_received());
+ std::string line;
+ EXPECT_TRUE(std::getline(in, line));
+ EXPECT_FALSE(std::getline(in, line));
+
+ TestRequestWithContext(CreateFileSystemURL("foo"),
+ file_system_context.get());
+ ASSERT_FALSE(request_->is_pending());
+ ASSERT_FALSE(request_->status().is_success());
+ EXPECT_EQ(net::ERR_FILE_NOT_FOUND, request_->status().error());
+}
+
} // namespace (anonymous)
} // namespace fileapi
« no previous file with comments | « webkit/browser/fileapi/file_system_dir_url_request_job.cc ('k') | webkit/browser/fileapi/file_system_url_request_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698