Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 23494028: Do not return FileSystem contents if the profile is in incognito mode. (Closed)

Created:
7 years, 3 months ago by kinuko
Modified:
7 years, 3 months ago
Reviewers:
tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org
Visibility:
Public.

Description

Do not return FileSystem contents if the profile is in incognito mode. BUG=178304 TEST=FileSystem{,Dir}URLRequestJobTest.* TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -10 lines) Patch
M webkit/browser/fileapi/file_system_context.h View 2 chunks +6 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job_unittest.cc View 3 chunks +33 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_unittest.cc View 6 chunks +34 lines, -6 lines 0 comments Download
M webkit/browser/fileapi/mock_file_system_context.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/mock_file_system_context.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_system_backend.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
PTL
7 years, 3 months ago (2013-09-05 13:19:37 UTC) #1
tzik
lgtm
7 years, 3 months ago (2013-09-06 06:15:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23494028/1
7 years, 3 months ago (2013-09-06 06:28:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=152007
7 years, 3 months ago (2013-09-06 08:06:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23494028/1
7 years, 3 months ago (2013-09-06 09:37:54 UTC) #5
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 10:19:25 UTC) #6
Message was sent while issue was closed.
Change committed as 221670

Powered by Google App Engine
This is Rietveld 408576698