Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 23494023: Mark URLRequest::GetResponseCode() as const (Closed)

Created:
7 years, 3 months ago by Boris Yusupov
Modified:
7 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Mark URLRequest::GetResponseCode() as const The URLRequestJob interface this forwards to is const, and marking URLRequest::GetResponseCode() as const allows passing the URLRequest as const in some cases. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/url_request/url_request.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Boris Yusupov
7 years, 3 months ago (2013-09-04 08:45:03 UTC) #1
Ryan Sleevi
lgtm Sorry for the delays on this.
7 years, 3 months ago (2013-09-06 20:24:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boriay@yandex-team.ru/23494023/1
7 years, 3 months ago (2013-09-06 20:24:31 UTC) #3
Ryan Sleevi
Note: I updated the CL description to try to be clearer when landing.
7 years, 3 months ago (2013-09-06 20:26:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boriay@yandex-team.ru/23494023/1
7 years, 3 months ago (2013-09-06 20:26:51 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=74992
7 years, 3 months ago (2013-09-07 00:04:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boriay@yandex-team.ru/23494023/1
7 years, 3 months ago (2013-09-08 12:27:22 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-08 23:35:17 UTC) #8
Message was sent while issue was closed.
Change committed as 221958

Powered by Google App Engine
This is Rietveld 408576698