Issue 23494022: Change active root window before closing old root windows' children.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23494022: Change active root window before closing old root windows' children. (Closed)

Created:
7 years, 3 months ago by flackr

Modified:
7 years, 3 months ago

Reviewers:
James Cook, oshima

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, oshima

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Change active root window before closing old root windows' children. BUG=282582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221497

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	ash/root_window_controller.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

flackr

PTAL, this should fix the crash mentioned in the bug. The circumstances under which the ...

7 years, 3 months ago (2013-09-05 13:13:49 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/23494022/1

7 years, 3 months ago (2013-09-05 17:23:10 UTC) #4

Message was sent while issue was closed.

Change committed as 221497