Issue 23494021: [Android] Provide a valid initial size for the overscroll effect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23494021: [Android] Provide a valid initial size for the overscroll effect (Closed)

Created:
7 years, 3 months ago by jdduke (slow)

Modified:
7 years, 3 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Provide a valid initial size for the overscroll effect Chrome on Android's overscroll effect is created on-demand, the first time a user overscrolls. Rather than wait for an update from the compositor to give the effect a valid size, provide the created effect the last valid content size. This prevents the initial overscroll hitch that may occur if the compositor is otherwise inactive when the first overscroll update is received. BUG=284523 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221200

Patch Set 1 #

Patch Set 2 : Explicit size on creation #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -5 lines)			Patch
M	content/browser/android/overscroll_glow.h	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/android/overscroll_glow.cc	View	1	2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/23494021/2

7 years, 3 months ago (2013-09-04 16:33:25 UTC) #3

Message was sent while issue was closed.

Change committed as 221200

Expand Messages | Collapse Messages