Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 23494018: Add optional parameter to WTFReportBacktrace for stackframe count (Closed)

Created:
7 years, 3 months ago by pdr.
Modified:
7 years, 3 months ago
CC:
blink-reviews, loislo+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, jeez
Visibility:
Public.

Description

Add optional parameter to WTFReportBacktrace for stackframe count This patch gives epic yakshavers an optional parameter to control how many stackframes to show when using WTFReportBacktrace. This just exposes a previously static framesToShow value. Users may find this useful in debugging deep traces. This patch does not modify the BACKTRACE macro because macros cannot have optional parameters. This patch does not use templates this function is in a c block which does not support templates ("templates must have C++ linkage"). TEST=manual Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157400

Patch Set 1 #

Patch Set 2 : Windows wants const ints #

Patch Set 3 : Explicitly allocate the stackframe array on the stack #

Patch Set 4 : Add comment explaining why alloca is being used #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/wtf/Assertions.h View 2 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Assertions.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pdr.
7 years, 3 months ago (2013-09-02 21:31:47 UTC) #1
tony
LGTM
7 years, 3 months ago (2013-09-04 16:51:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/23494018/1
7 years, 3 months ago (2013-09-04 17:00:24 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-04 17:58:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/23494018/4001
7 years, 3 months ago (2013-09-04 20:41:22 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 3 months ago (2013-09-04 21:23:05 UTC) #6
pdr.
On 2013/09/04 21:23:05, I haz the power (commit-bot) wrote: > Sorry for I got bad ...
7 years, 3 months ago (2013-09-06 00:10:19 UTC) #7
esprehn
On 2013/09/06 00:10:19, pdr wrote: > On 2013/09/04 21:23:05, I haz the power (commit-bot) wrote: ...
7 years, 3 months ago (2013-09-06 00:25:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/23494018/28001
7 years, 3 months ago (2013-09-06 21:56:59 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 00:35:06 UTC) #10
Message was sent while issue was closed.
Change committed as 157400

Powered by Google App Engine
This is Rietveld 408576698