Issue 23493025: Close Views autofill dialog on interstitial WebUI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23493025: Close Views autofill dialog on interstitial WebUI (Closed)

Created:
7 years, 3 months ago by Mike Wittman

Modified:
7 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, benquan, tfarina, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Close Views autofill dialog on interstitial WebUI Configure Views autofill dialogs to be closed when interstitial WebUI is displayed (e.g. for SSL warnings prior to page load). BUG=240575 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221884

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wittman@chromium.org/23493025/1

7 years, 3 months ago (2013-09-07 00:22:09 UTC) #3

Message was sent while issue was closed.

Change committed as 221884

Expand Messages | Collapse Messages