Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 23493021: Use webview.request in OAuth scope approval dialog. (Closed)

Created:
7 years, 3 months ago by Michael Courage
Modified:
7 years, 3 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, Fady Samuel
Visibility:
Public.

Description

Use webview.request in OAuth scope approval dialog. The WebRequest API on webviews moved to a new location. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/identity_scope_approval_dialog/scope_approval_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Courage
7 years, 3 months ago (2013-09-05 23:22:29 UTC) #1
xiyuan
lgtm
7 years, 3 months ago (2013-09-06 00:58:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/courage@chromium.org/23493021/1
7 years, 3 months ago (2013-09-06 01:17:19 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 05:51:01 UTC) #4
Message was sent while issue was closed.
Change committed as 221589

Powered by Google App Engine
This is Rietveld 408576698