Issue 23490021: Rename chrome/browser/devtools/tethering_adb_filter.* to port_forwarding_controller.*

Issue 23490021: Rename chrome/browser/devtools/tethering_adb_filter.* to port_forwarding_controller.* (Closed)

Created:
7 years, 3 months ago by Vladislav Kaznacheev

Modified:
7 years, 3 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rename chrome/browser/devtools/tethering_adb_filter.* to port_forwarding_controller.* Also moved TetheringAdbFilter class declaration into a cc file, preparing for merge with PortForwardingController::Connection. TBR=jam (file renamed in chrome.gyp) BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220560

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments, uploaded with lower similarity threshold #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -769 lines)			Patch
M	chrome/browser/devtools/devtools_adb_bridge.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	chrome/browser/devtools/port_forwarding_controller.h	View	1	2 chunks	+6 lines, -71 lines	0 comments	Download
A +	chrome/browser/devtools/port_forwarding_controller.cc	View		3 chunks	+60 lines, -1 line	0 comments	Download
D	chrome/browser/devtools/tethering_adb_filter.h	View		1 chunk	+0 lines, -100 lines	0 comments	Download
D	chrome/browser/devtools/tethering_adb_filter.cc	View		1 chunk	+0 lines, -594 lines	0 comments	Download
M	chrome/chrome.gyp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pfeldman

lgtm https://codereview.chromium.org/23490021/diff/1/chrome/browser/devtools/port_forwarding_controller.h File chrome/browser/devtools/port_forwarding_controller.h (right): https://codereview.chromium.org/23490021/diff/1/chrome/browser/devtools/port_forwarding_controller.h#newcode20 chrome/browser/devtools/port_forwarding_controller.h:20: virtual ~PortForwardingController(); Does it have to be virtual? ...

7 years, 3 months ago (2013-08-30 09:31:15 UTC) #2

Vladislav Kaznacheev

https://chromiumcodereview.appspot.com/23490021/diff/1/chrome/browser/devtools/port_forwarding_controller.h File chrome/browser/devtools/port_forwarding_controller.h (right): https://chromiumcodereview.appspot.com/23490021/diff/1/chrome/browser/devtools/port_forwarding_controller.h#newcode20 chrome/browser/devtools/port_forwarding_controller.h:20: virtual ~PortForwardingController(); On 2013/08/30 09:31:15, pfeldman wrote: > Does ...

7 years, 3 months ago (2013-08-30 09:43:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kaznacheev@chromium.org/23490021/5001

7 years, 3 months ago (2013-08-30 09:45:06 UTC) #4

Message was sent while issue was closed.

Change committed as 220560

Expand Messages | Collapse Messages