Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 23490017: Adds some debugging code to isolate a crash (Closed)

Created:
7 years, 3 months ago by sky
Modified:
7 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su
Visibility:
Public.

Description

Adds some debugging code to isolate a crash Crash data seems to indicate AutocompletePopupWidget is getting destroyed when we Init() it. This seems wrong, so I'm adding a CHECK to helkp isolate why. BUG=275794 TEST=none R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220451

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
7 years, 3 months ago (2013-08-29 16:50:42 UTC) #1
Peter Kasting
LGTM
7 years, 3 months ago (2013-08-29 18:17:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/23490017/1
7 years, 3 months ago (2013-08-29 19:27:04 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 00:31:46 UTC) #4
Message was sent while issue was closed.
Change committed as 220451

Powered by Google App Engine
This is Rietveld 408576698