Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 23490012: Replace O(n^2) set intersection test with O(n) (Closed)

Created:
7 years, 3 months ago by jsbell
Modified:
7 years, 3 months ago
Reviewers:
alecflett, dgrogan
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Replace O(n^2) set intersection test with O(n) The original Blink code used unordered WTF sets, and we missed this when porting the back end to Chromium and std::set. BUG=280741 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M content/browser/indexed_db/indexed_db_transaction_coordinator.cc View 3 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jsbell
Odds are we'll never notice the performance difference, but it doesn't introduce code complexity and ...
7 years, 3 months ago (2013-08-28 22:57:53 UTC) #1
dgrogan
LGTM Did you overlook or reject std::set_intersection?
7 years, 3 months ago (2013-08-28 23:05:29 UTC) #2
jsbell
On 2013/08/28 23:05:29, dgrogan wrote: > LGTM > > Did you overlook or reject std::set_intersection? ...
7 years, 3 months ago (2013-08-28 23:36:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jsbell@chromium.org/23490012/1
7 years, 3 months ago (2013-08-29 18:24:34 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-29 23:03:29 UTC) #5
Message was sent while issue was closed.
Change committed as 220416

Powered by Google App Engine
This is Rietveld 408576698