Add APIs to cache navigation info and send via callback

Add APIs to cache navigation info and send via callback

Adds no-op APIs to cache navigation info for custom tabs like
url, title and content screenshot and send them via a callback
to the client app.

BUG=647342
Committed: https://crrev.com/aad14f9e479d6fa9076f059e26c5e825377642fa
Cr-Commit-Position: refs/heads/master@{#419328}

[Yusuf, 2016-09-15 19:49:33]

yusufo@chromium.org changed reviewers:
+ ianwen@chromium.org

[Ian Wen, 2016-09-16 22:32:40]

lgtm after comments.

https://chromiumcodereview.appspot.com/2348573002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
(right):

https://chromiumcodereview.appspot.com/2348573002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java:56:
Rect bounds = ExternalPrerenderHandler.estimateContentSize(application, false);
Special case if bounds is 0? In this case, mark scale to be 1 or some value?

https://chromiumcodereview.appspot.com/2348573002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java:60:
mScaleForNavigationInfo = 1f;
You could pre-initialize mScale to 1f above, and remove the if/else here.

[Yusuf, 2016-09-16 22:41:00]

https://codereview.chromium.org/2348573002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java
(right):

https://codereview.chromium.org/2348573002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java:56:
Rect bounds = ExternalPrerenderHandler.estimateContentSize(application, false);
On 2016/09/16 22:32:39, Ian Wen wrote:
> Special case if bounds is 0? In this case, mark scale to be 1 or some value?

Done.

https://codereview.chromium.org/2348573002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabObserver.java:60:
mScaleForNavigationInfo = 1f;
On 2016/09/16 22:32:40, Ian Wen wrote:
> You could pre-initialize mScale to 1f above, and remove the if/else here.

Done.

[Yusuf, 2016-09-16 22:41:07]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2016-09-16 22:41:08]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2348573002/#ps20001
(title: "Nits")

[commit-bot: I haz the power, 2016-09-16 22:41:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 23:37:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-16 23:40:31]

Description was changed from

==========
Add APIs to cache navigation info and send via callback

Adds no-op APIs to cache navigation info for custom tabs like
url, title and content screenshot and send them via a callback
to the client app.

BUG=647342
==========

to

==========
Add APIs to cache navigation info and send via callback

Adds no-op APIs to cache navigation info for custom tabs like
url, title and content screenshot and send them via a callback
to the client app.

BUG=647342

Committed: https://crrev.com/aad14f9e479d6fa9076f059e26c5e825377642fa
Cr-Commit-Position: refs/heads/master@{#419328}
==========

[commit-bot: I haz the power, 2016-09-16 23:40:32]

Patchset 2 (id:??) landed as
https://crrev.com/aad14f9e479d6fa9076f059e26c5e825377642fa
Cr-Commit-Position: refs/heads/master@{#419328}