Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 23484060: Optimize typed-array length loading. (Closed)

Created:
7 years, 3 months ago by Toon Verwaest
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Optimize typed-array length loading. R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16845

Patch Set 1 #

Total comments: 1

Patch Set 2 : Now actually correct #

Patch Set 3 : Fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -6 lines) Patch
M src/hydrogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ic.cc View 1 2 2 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Toon Verwaest
PTAL
7 years, 3 months ago (2013-09-19 17:22:09 UTC) #1
Dmitry Lomov (no reviews)
https://codereview.chromium.org/23484060/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/23484060/diff/1/src/ic.cc#newcode1380 src/ic.cc:1380: } else if (receiver->IsJSTypedArray()) { Are you sure you ...
7 years, 3 months ago (2013-09-19 17:45:46 UTC) #2
Toon Verwaest
You are right, I realized its not. And somehow when I move it up, the ...
7 years, 3 months ago (2013-09-19 17:46:57 UTC) #3
Toon Verwaest
PTAL again.
7 years, 3 months ago (2013-09-19 18:02:18 UTC) #4
Dmitry Lomov (no reviews)
lgtm! Thanks for taking care of this.
7 years, 3 months ago (2013-09-19 18:07:24 UTC) #5
Dmitry Lomov (no reviews)
On 2013/09/19 18:07:24, Dmitry Lomov (chromium) wrote: > lgtm! Thanks for taking care of this. ...
7 years, 3 months ago (2013-09-19 18:18:03 UTC) #6
Dmitry Lomov (no reviews)
On 2013/09/19 18:07:24, Dmitry Lomov (chromium) wrote: > lgtm! Thanks for taking care of this. ...
7 years, 3 months ago (2013-09-19 18:18:06 UTC) #7
Toon Verwaest
7 years, 3 months ago (2013-09-19 18:19:35 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r16845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698