Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 23484053: Remove FINAL_STATUS_HTML5_MEDIA and related messages. (Closed)

Created:
7 years, 3 months ago by davidben
Modified:
7 years, 3 months ago
Reviewers:
jschuh, mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove FINAL_STATUS_HTML5_MEDIA and related messages. They've been unused since r113742 when audio/video became deferred on prerender. Also update a comment to account for media no longer being cancelled that way. Also remove some other dead code. BUG=none TEST=compiles, PrerenderBrowserTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224766

Patch Set 1 #

Patch Set 2 : Delete more dead code. #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -28 lines) Patch
M chrome/browser/prerender/prerender_final_status.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_render_view_host_observer.h View 1 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_render_view_host_observer.cc View 1 2 chunks +1 line, -13 lines 0 comments Download
M chrome/common/render_messages.h View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
davidben
Noticed this as I was reading code. jschuh: for chrome/common/render_messages.h (I'm just deleting an IPC)
7 years, 3 months ago (2013-09-18 18:11:18 UTC) #1
mmenke
On 2013/09/18 18:11:18, David Benjamin wrote: > Noticed this as I was reading code. > ...
7 years, 3 months ago (2013-09-18 18:16:28 UTC) #2
davidben
jschuh: ping Trimmed off a little bit more code. I suspect we can get rid ...
7 years, 3 months ago (2013-09-19 18:55:12 UTC) #3
mmenke
https://codereview.chromium.org/23484053/diff/9001/chrome/browser/prerender/prerender_final_status.h File chrome/browser/prerender/prerender_final_status.h (right): https://codereview.chromium.org/23484053/diff/9001/chrome/browser/prerender/prerender_final_status.h#newcode35 chrome/browser/prerender/prerender_final_status.h:35: FINAL_STATUS_SOURCE_RENDER_VIEW_CLOSED = 20, Doesn't look like this isn't used ...
7 years, 3 months ago (2013-09-19 19:52:33 UTC) #4
davidben
https://codereview.chromium.org/23484053/diff/9001/chrome/browser/prerender/prerender_final_status.h File chrome/browser/prerender/prerender_final_status.h (right): https://codereview.chromium.org/23484053/diff/9001/chrome/browser/prerender/prerender_final_status.h#newcode35 chrome/browser/prerender/prerender_final_status.h:35: FINAL_STATUS_SOURCE_RENDER_VIEW_CLOSED = 20, On 2013/09/19 19:52:33, mmenke wrote: > ...
7 years, 3 months ago (2013-09-19 20:04:12 UTC) #5
jschuh
ipc security lgtm: message removal :)
7 years, 3 months ago (2013-09-19 21:08:18 UTC) #6
mmenke
On 2013/09/19 21:08:18, Justin Schuh wrote: > ipc security lgtm: message removal :) Still LGTM ...
7 years, 3 months ago (2013-09-19 21:10:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/23484053/21001
7 years, 3 months ago (2013-09-19 21:21:15 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=199569
7 years, 3 months ago (2013-09-20 02:09:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/23484053/21001
7 years, 3 months ago (2013-09-20 18:35:38 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-20 18:48:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/23484053/21001
7 years, 3 months ago (2013-09-20 19:40:36 UTC) #12
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=200357
7 years, 3 months ago (2013-09-20 22:15:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/23484053/21001
7 years, 3 months ago (2013-09-23 15:32:44 UTC) #14
commit-bot: I haz the power
7 years, 3 months ago (2013-09-23 19:26:23 UTC) #15
Message was sent while issue was closed.
Change committed as 224766

Powered by Google App Engine
This is Rietveld 408576698