Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 23484036: Add newlines to the end of files where they were missing (Closed)

Created:
7 years, 3 months ago by hans
Modified:
7 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, kkania, amit, Ilya Sherman, extensions-reviews_chromium.org, benquan, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, Albert Bodenhamer, sergeyu+watch_chromium.org, rouslan+autofillwatch_chromium.org, michaeln, hclam+watch_chromium.org, tfarina, frankf, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, alexeypa+watch_chromium.org
Visibility:
Public.

Description

Add newlines to the end of files where they were missing This fixes warnings from a recent Clang version. BUG=290204 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222838

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M base/barrier_closure.h View 1 chunk +1 line, -1 line 0 comments Download
M base/barrier_closure.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/parallel_test_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/power_monitor_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M base/test/unit_test_launcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_fullscreen_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/cpp_source.py View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/power_monitor_message_broadcaster.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/power_monitor_message_broadcaster.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/appcache/appcache_backend_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/audio_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
media/base/audio_hash.h View 1 chunk +1 line, -1 line 0 comments Download
media/base/audio_hash.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/audio_hash_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/scoped_histogram_timer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/host/message_filter_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/url_loader_resource.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/url_loader_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_trace_event.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/audio_silence_detector.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hans
I made an attempt to roll Clang to r189214 and noticed it has started warning ...
7 years, 3 months ago (2013-09-12 01:33:39 UTC) #1
Nico
lgtm Maybe file a tracking bug for rolling clang and put that in the BUG ...
7 years, 3 months ago (2013-09-12 03:07:11 UTC) #2
hans
On 2013/09/12 03:07:11, Nico wrote: > lgtm > > Maybe file a tracking bug for ...
7 years, 3 months ago (2013-09-12 16:01:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/23484036/1
7 years, 3 months ago (2013-09-12 16:01:35 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/cocoa/autofill/autofill_overlay_controller.mm: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 3 months ago (2013-09-12 16:01:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/23484036/16001
7 years, 3 months ago (2013-09-12 16:20:39 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-12 19:48:24 UTC) #7
Message was sent while issue was closed.
Change committed as 222838

Powered by Google App Engine
This is Rietveld 408576698