Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 23483042: Replace uses of GrNoncopyable by SkNoncopyable. (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 3 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Replace uses of GrNoncopyable by SkNoncopyable. BUG=None TEST=None, no functional changes. R=bsalomon@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=11341

Patch Set 1 #

Patch Set 2 : gpu/gl #

Patch Set 3 : include/gpu #

Patch Set 4 : rm GrNoncopyable.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -127 lines) Patch
M gyp/gpu.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M gyp/public_headers.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrBackendEffectFactory.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 2 5 chunks +7 lines, -6 lines 0 comments Download
M include/gpu/GrContextFactory.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/GrEffect.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrEffectUnitTest.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D include/gpu/GrNoncopyable.h View 1 2 3 1 chunk +0 lines, -28 lines 0 comments Download
M include/gpu/GrTextureAccess.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrAllocPool.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/GrAllocPool.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/GrAllocator.h View 4 chunks +6 lines, -9 lines 0 comments Download
M src/gpu/GrBufferAllocPool.h View 3 chunks +2 lines, -7 lines 0 comments Download
M src/gpu/GrClipMaskCache.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 5 chunks +5 lines, -7 lines 0 comments Download
M src/gpu/GrDrawState.h View 5 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 6 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 6 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/GrPlotMgr.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrRedBlackTree.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrTemplates.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/effects/GrTextureStripAtlas.h View 1 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLBufferImpl.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/debug/GrFakeRefObj.h View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
s&r :/
7 years, 3 months ago (2013-09-14 01:30:06 UTC) #1
robertphillips
lgtm
7 years, 3 months ago (2013-09-16 12:47:52 UTC) #2
bsalomon
lgtm
7 years, 3 months ago (2013-09-16 13:18:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/23483042/2
7 years, 3 months ago (2013-09-16 13:18:28 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-18 13:01:12 UTC) #5
Message was sent while issue was closed.
Change committed as 11341

Powered by Google App Engine
This is Rietveld 408576698