Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tests/project_test.py

Issue 23483019: Changes to support One-Click Revert in Commit Queue (Closed) Base URL: https://src.chromium.org/chrome/trunk/tools/commit-queue/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/pending_manager_test.py ('k') | tests/try_server_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/project_test.py
===================================================================
--- tests/project_test.py (revision 220012)
+++ tests/project_test.py (working copy)
@@ -125,6 +125,8 @@
],
'pre_patch_verifiers': ['project_bases', 'reviewer_lgtm'],
'verifiers': ['try job rietveld', 'tree status'],
+ 'pre_patch_revert_verifiers': [],
+ 'revert_verifiers': []
},
'chromium': {
'lines': [
@@ -132,6 +134,8 @@
],
'pre_patch_verifiers': ['project_bases', 'reviewer_lgtm'],
'verifiers': ['try job rietveld', 'tree status'],
+ 'pre_patch_revert_verifiers': [],
+ 'revert_verifiers': []
},
'chromium_deps': {
'lines': [
@@ -139,6 +143,8 @@
],
'pre_patch_verifiers': ['project_bases', 'reviewer_lgtm'],
'verifiers': ['presubmit'],
+ 'pre_patch_revert_verifiers': [],
+ 'revert_verifiers': []
},
'gyp': {
'lines': [
@@ -146,6 +152,8 @@
],
'pre_patch_verifiers': ['project_bases', 'reviewer_lgtm'],
'verifiers': ['tree status'],
+ 'pre_patch_revert_verifiers': [],
+ 'revert_verifiers': []
},
'nacl': {
'lines': [
@@ -153,6 +161,8 @@
],
'pre_patch_verifiers': ['project_bases', 'reviewer_lgtm'],
'verifiers': ['presubmit', 'tree status'],
+ 'pre_patch_revert_verifiers': [],
+ 'revert_verifiers': []
},
'skia': {
'lines': [
@@ -160,6 +170,8 @@
],
'pre_patch_verifiers': ['project_bases', 'reviewer_lgtm'],
'verifiers': ['presubmit', 'tree status'],
+ 'pre_patch_revert_verifiers': ['project_bases', 'committer_revert'],
+ 'revert_verifiers': []
},
'tools': {
'lines': [
@@ -167,6 +179,8 @@
],
'pre_patch_verifiers': ['project_bases', 'reviewer_lgtm'],
'verifiers': ['presubmit'],
+ 'pre_patch_revert_verifiers': [],
+ 'revert_verifiers': []
},
}
for project in sorted(projects.supported_projects()):
@@ -187,6 +201,17 @@
(expected['verifiers'],
[x.name for x in p.verifiers],
project))
+ self.assertEqual(
+ expected['pre_patch_revert_verifiers'],
+ [x.name for x in p.pre_patch_revert_verifiers],
+ (expected['pre_patch_revert_verifiers'],
+ [x.name for x in p.pre_patch_revert_verifiers],
+ project))
+ self.assertEqual(
+ expected['revert_verifiers'], [x.name for x in p.revert_verifiers],
+ (expected['revert_verifiers'],
+ [x.name for x in p.revert_verifiers],
+ project))
if project == 'tools':
# Add special checks for it.
project_bases_verifier = p.pre_patch_verifiers[0]
@@ -489,9 +514,9 @@
])
self.context.checkout.check_calls([
'prepare(None)',
- 'apply_patch(%r)' % self.context.rietveld.patchsets[0],
+ 'apply_patch(%r, revert=False)' % self.context.rietveld.patchsets[0],
'prepare(None)',
- 'apply_patch(%r)' % self.context.rietveld.patchsets[1],
+ 'apply_patch(%r, revert=False)' % self.context.rietveld.patchsets[1],
"commit(u'foo\\nTBR=\\n\\nReview URL: http://nowhere/31337', "
"u'user@example.com')",
])
« no previous file with comments | « tests/pending_manager_test.py ('k') | tests/try_server_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698