Issue 23480094: Set the proper instance-type on HAllocate in BuildFastLiteral

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23480094: Set the proper instance-type on HAllocate in BuildFastLiteral (Closed)

Created:
7 years, 3 months ago by Toon Verwaest

Modified:
7 years, 3 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Set the proper instance-type on HAllocate in BuildFastLiteral BUG=chromium:284577 R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16790

Patch Set 2 : Addressed comment #

Patch Set 3 : Added assert #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	src/hydrogen.cc	View	1 2	2 chunks	+7 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hannes Payer (out of office)

awesome LGTM! one nit https://codereview.chromium.org/23480094/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/23480094/diff/1/src/hydrogen.cc#newcode8213 src/hydrogen.cc:8213: HInstruction* object = Add<HAllocate>(object_size_constant, HType::JSObject(), ...

7 years, 3 months ago (2013-09-18 14:03:15 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r16790.