Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23480046: Add Photos to a background permission whitelist. (Closed)

Created:
7 years, 3 months ago by Dmitry Titov
Modified:
7 years, 3 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, James Hawkins
Visibility:
Public.

Description

Add Photos to a background permission whitelist. BUG=286542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221931

Patch Set 1 #

Patch Set 2 : nicer-looking IDs... #

Patch Set 3 : yay, obscurity! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M chrome/common/extensions/api/_permission_features.json View 1 2 2 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Dmitry Titov
Mike, this is a new entry for the "background" permission whitelist for G+ Photos... Don't ...
7 years, 3 months ago (2013-09-06 22:43:19 UTC) #1
miket_OOO
lgtm
7 years, 3 months ago (2013-09-06 22:58:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/23480046/21001
7 years, 3 months ago (2013-09-06 23:58:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/23480046/25001
7 years, 3 months ago (2013-09-07 00:11:49 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=24266
7 years, 3 months ago (2013-09-07 00:29:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/23480046/25001
7 years, 3 months ago (2013-09-07 14:03:40 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-07 14:09:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dimich@chromium.org/23480046/25001
7 years, 3 months ago (2013-09-07 19:57:44 UTC) #8
commit-bot: I haz the power
7 years, 3 months ago (2013-09-07 23:27:31 UTC) #9
Message was sent while issue was closed. 
Change committed as 221931

Powered by Google App Engine
This is Rietveld 408576698