Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: Source/core/platform/ScrollableArea.h

Issue 23480037: Fix RTL scroll bars being misrendered on Android. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: isLeftSideVerticalScrollbar Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/platform/ScrollableArea.h
diff --git a/Source/core/platform/ScrollableArea.h b/Source/core/platform/ScrollableArea.h
index ca6614586a02dc056d037acb0d3c53ea05823d72..4494722b3fe4d5e686c7f1a196949ab4728d7fb6 100644
--- a/Source/core/platform/ScrollableArea.h
+++ b/Source/core/platform/ScrollableArea.h
@@ -27,7 +27,6 @@
#define ScrollableArea_h
#include "core/platform/Scrollbar.h"
-#include "core/platform/text/TextDirection.h"
#include "wtf/Vector.h"
namespace WebCore {
@@ -180,6 +179,7 @@ public:
virtual void updateNeedsCompositedScrolling() { }
virtual bool userInputScrollable(ScrollbarOrientation) const = 0;
+ virtual bool shouldPlaceVerticalScrollbarOnLeft() const = 0;
// Convenience functions
int scrollPosition(ScrollbarOrientation orientation) { return orientation == HorizontalScrollbar ? scrollPosition().x() : scrollPosition().y(); }
@@ -187,8 +187,6 @@ public:
int maximumScrollPosition(ScrollbarOrientation orientation) { return orientation == HorizontalScrollbar ? maximumScrollPosition().x() : maximumScrollPosition().y(); }
int clampScrollPosition(ScrollbarOrientation orientation, int pos) { return std::max(std::min(pos, maximumScrollPosition(orientation)), minimumScrollPosition(orientation)); }
- TextDirection textDirection() const;
-
protected:
ScrollableArea();
virtual ~ScrollableArea();

Powered by Google App Engine
This is Rietveld 408576698