Source/web/ScrollbarGroup.h - Issue 23480037: Fix RTL scroll bars being misrendered on Android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/ScrollbarGroup.h

Issue 23480037: Fix RTL scroll bars being misrendered on Android. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: isLeftSideVerticalScrollbar Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/rendering/RenderListBox.cpp ('k') | Source/web/ScrollbarGroup.cpp » ('j') | Source/web/ScrollbarGroup.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 virtual int visibleHeight() const OVERRIDE;	67 virtual int visibleHeight() const OVERRIDE;

68 virtual int visibleWidth() const OVERRIDE;	68 virtual int visibleWidth() const OVERRIDE;

69 virtual WebCore::IntSize contentsSize() const OVERRIDE;	69 virtual WebCore::IntSize contentsSize() const OVERRIDE;

70 virtual WebCore::IntSize overhangAmount() const OVERRIDE;	70 virtual WebCore::IntSize overhangAmount() const OVERRIDE;

71 virtual WebCore::IntPoint lastKnownMousePosition() const OVERRIDE;	71 virtual WebCore::IntPoint lastKnownMousePosition() const OVERRIDE;

72 virtual bool shouldSuspendScrollAnimations() const OVERRIDE;	72 virtual bool shouldSuspendScrollAnimations() const OVERRIDE;

73 virtual void scrollbarStyleChanged(int newStyle, bool forceUpdate) OVERRIDE;	73 virtual void scrollbarStyleChanged(int newStyle, bool forceUpdate) OVERRIDE;

74 virtual bool scrollbarsCanBeActive() const OVERRIDE;	74 virtual bool scrollbarsCanBeActive() const OVERRIDE;

75 virtual WebCore::IntRect scrollableAreaBoundingBox() const OVERRIDE;	75 virtual WebCore::IntRect scrollableAreaBoundingBox() const OVERRIDE;

76 virtual bool userInputScrollable(WebCore::ScrollbarOrientation) const OVERRI DE;	76 virtual bool userInputScrollable(WebCore::ScrollbarOrientation) const OVERRI DE;

	77 virtual bool shouldPlaceVerticalScrollbarOnLeft() const OVERRIDE;

77 virtual int pageStep(WebCore::ScrollbarOrientation) const OVERRIDE;	78 virtual int pageStep(WebCore::ScrollbarOrientation) const OVERRIDE;

78	79

79 private:	80 private:

80 WebCore::FrameView* m_frameView;	81 WebCore::FrameView* m_frameView;

81 WebCore::IntPoint m_lastMousePosition;	82 WebCore::IntPoint m_lastMousePosition;

82 WebCore::IntRect m_frameRect;	83 WebCore::IntRect m_frameRect;

83 WebPluginScrollbarImpl* m_horizontalScrollbar;	84 WebPluginScrollbarImpl* m_horizontalScrollbar;

84 WebPluginScrollbarImpl* m_verticalScrollbar;	85 WebPluginScrollbarImpl* m_verticalScrollbar;

85 };	86 };

86	87

87 } // namespace WebKit	88 } // namespace WebKit

88	89

89 #endif	90 #endif

OLD	NEW