Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: Source/core/platform/Scrollbar.cpp

Issue 23480037: Fix RTL scroll bars being misrendered on Android. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: isLeftSideVerticalScrollbar Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 bool Scrollbar::isScrollableAreaActive() const 114 bool Scrollbar::isScrollableAreaActive() const
115 { 115 {
116 return m_scrollableArea && m_scrollableArea->isActive(); 116 return m_scrollableArea && m_scrollableArea->isActive();
117 } 117 }
118 118
119 bool Scrollbar::isScrollViewScrollbar() const 119 bool Scrollbar::isScrollViewScrollbar() const
120 { 120 {
121 return parent() && parent()->isFrameView() && toFrameView(parent())->isScrol lViewScrollbar(this); 121 return parent() && parent()->isFrameView() && toFrameView(parent())->isScrol lViewScrollbar(this);
122 } 122 }
123 123
124 TextDirection Scrollbar::textDirection() const 124 bool Scrollbar::isLeftSideVerticalScrollbar() const
125 { 125 {
126 if (m_orientation == VerticalScrollbar && m_scrollableArea) 126 if (m_orientation == VerticalScrollbar && m_scrollableArea)
127 return m_scrollableArea->textDirection(); 127 return m_scrollableArea->shouldPlaceVerticalScrollbarOnLeft();
128 return LTR; 128 return false;
129 } 129 }
130 130
131 void Scrollbar::offsetDidChange() 131 void Scrollbar::offsetDidChange()
132 { 132 {
133 ASSERT(m_scrollableArea); 133 ASSERT(m_scrollableArea);
134 134
135 float position = scrollableAreaCurrentPos(); 135 float position = scrollableAreaCurrentPos();
136 if (position == m_currentPos) 136 if (position == m_currentPos)
137 return; 137 return;
138 138
(...skipping 456 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 if (!m_scrollableArea) 595 if (!m_scrollableArea)
596 return 0; 596 return 0;
597 597
598 if (m_orientation == HorizontalScrollbar) 598 if (m_orientation == HorizontalScrollbar)
599 return m_scrollableArea->scrollPosition().x() - m_scrollableArea->minimu mScrollPosition().x(); 599 return m_scrollableArea->scrollPosition().x() - m_scrollableArea->minimu mScrollPosition().x();
600 600
601 return m_scrollableArea->scrollPosition().y() - m_scrollableArea->minimumScr ollPosition().y(); 601 return m_scrollableArea->scrollPosition().y() - m_scrollableArea->minimumScr ollPosition().y();
602 } 602 }
603 603
604 } // namespace WebCore 604 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698