Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: Source/core/platform/ScrollView.h

Issue 23480037: Fix RTL scroll bars being misrendered on Android. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: isLeftSideVerticalScrollbar Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Holger Hans Peter Freyther 3 * Copyright (C) 2009 Holger Hans Peter Freyther
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 class ScrollView : public Widget, public ScrollableArea { 43 class ScrollView : public Widget, public ScrollableArea {
44 public: 44 public:
45 ~ScrollView(); 45 ~ScrollView();
46 46
47 // ScrollableArea functions. 47 // ScrollableArea functions.
48 virtual int scrollSize(ScrollbarOrientation) const OVERRIDE; 48 virtual int scrollSize(ScrollbarOrientation) const OVERRIDE;
49 virtual void setScrollOffset(const IntPoint&) OVERRIDE; 49 virtual void setScrollOffset(const IntPoint&) OVERRIDE;
50 virtual bool isScrollCornerVisible() const OVERRIDE; 50 virtual bool isScrollCornerVisible() const OVERRIDE;
51 virtual void scrollbarStyleChanged(int newStyle, bool forceUpdate) OVERRIDE; 51 virtual void scrollbarStyleChanged(int newStyle, bool forceUpdate) OVERRIDE;
52 virtual bool userInputScrollable(ScrollbarOrientation) const OVERRIDE; 52 virtual bool userInputScrollable(ScrollbarOrientation) const OVERRIDE;
53 virtual bool shouldPlaceVerticalScrollbarOnLeft() const OVERRIDE;
53 54
54 virtual void notifyPageThatContentAreaWillPaint() const; 55 virtual void notifyPageThatContentAreaWillPaint() const;
55 56
56 // NOTE: This should only be called by the overriden setScrollOffset from Sc rollableArea. 57 // NOTE: This should only be called by the overriden setScrollOffset from Sc rollableArea.
57 virtual void scrollTo(const IntSize& newOffset); 58 virtual void scrollTo(const IntSize& newOffset);
58 59
59 // The window thats hosts the ScrollView. The ScrollView will communicate sc rolls and repaints to the 60 // The window thats hosts the ScrollView. The ScrollView will communicate sc rolls and repaints to the
60 // host window in the window's coordinate space. 61 // host window in the window's coordinate space.
61 virtual HostWindow* hostWindow() const = 0; 62 virtual HostWindow* hostWindow() const = 0;
62 63
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
355 ASSERT(!widget || widget->isScrollView()); 356 ASSERT(!widget || widget->isScrollView());
356 return static_cast<const ScrollView*>(widget); 357 return static_cast<const ScrollView*>(widget);
357 } 358 }
358 359
359 // This will catch anyone doing an unnecessary cast. 360 // This will catch anyone doing an unnecessary cast.
360 void toScrollView(const ScrollView*); 361 void toScrollView(const ScrollView*);
361 362
362 } // namespace WebCore 363 } // namespace WebCore
363 364
364 #endif // ScrollView_h 365 #endif // ScrollView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698