Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 23480018: Fix page_cycler unittests. (Closed)

Created:
7 years, 3 months ago by achuithb
Modified:
7 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Fix page_cycler unittests BrowserOptions->BrowserFinderOptions. BUG=269131 TEST=trybot Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220497

Patch Set 1 #

Patch Set 2 : Also fix bisect scripts #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/bisect-manual-test.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/page_cycler_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/run-bisect-manual-test.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
achuithb
Please take a look, Dave.
7 years, 3 months ago (2013-08-29 23:15:13 UTC) #1
achuithb
Based on https://codereview.chromium.org/23486002/
7 years, 3 months ago (2013-08-29 23:45:08 UTC) #2
tonyg
lgtm
7 years, 3 months ago (2013-08-29 23:48:10 UTC) #3
achuithb
On 2013/08/29 23:48:10, tonyg wrote: > lgtm ty!
7 years, 3 months ago (2013-08-29 23:49:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23480018/8001
7 years, 3 months ago (2013-08-29 23:51:16 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=164493
7 years, 3 months ago (2013-08-30 02:38:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/achuith@chromium.org/23480018/8001
7 years, 3 months ago (2013-08-30 02:42:35 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 03:37:07 UTC) #8
Message was sent while issue was closed.
Change committed as 220497

Powered by Google App Engine
This is Rietveld 408576698