Refactor distributor API so that methods always get the Quest_Desc too.

Refactor distributor API so that methods always get the Quest_Desc too.

This is so that various methods can see the original quest description body,
which can contain data directed at the distributor (or the distributor adaptor
in the case of swarming).

R=dnj@chromium.org, vadimsh@chromium.org
BUG=639975
Committed: https://github.com/luci/luci-go/commit/fa6f67917f657b339926828ac352e26e4d4dfb1e

[iannucci, 2016-09-19 18:16:43]

Monday morning PTAL Ping

[Vadim Sh., 2016-09-20 00:24:26]

lgtm with nits

https://codereview.chromium.org/2347973003/diff/1/dm/appengine/distributor/co...
File dm/appengine/distributor/config.go (right):

https://codereview.chromium.org/2347973003/diff/1/dm/appengine/distributor/co...
dm/appengine/distributor/config.go:53: topic =
pubsub.NewTopic(info.Get(c).TrimmedAppID(), notifyTopicSuffix)
consider caching the flag that this work has been done already, e.g. here's how
luci-scheduler does it:
https://github.com/luci/luci-go/blob/master/scheduler/appengine/engine/engine...

https://codereview.chromium.org/2347973003/diff/1/dm/appengine/distributor/di...
File dm/appengine/distributor/distributor.go (right):

https://codereview.chromium.org/2347973003/diff/1/dm/appengine/distributor/di...
dm/appengine/distributor/distributor.go:15: //     record its Token.
Additionally, the distributor SHOULD subscribe to
"should subscribe to publish on topic"

I cannot parse this.

https://codereview.chromium.org/2347973003/diff/1/dm/appengine/distributor/fa...
File dm/appengine/distributor/fake/fake.go (right):

https://codereview.chromium.org/2347973003/diff/1/dm/appengine/distributor/fa...
dm/appengine/distributor/fake/fake.go:257: tok = MkToken(exAuth.Id)
is it really that difficult to type two more letters to make it "MakeToken"? :)
I'm just curious why...

[iannucci, 2016-09-20 00:51:28]

https://chromiumcodereview.appspot.com/2347973003/diff/1/dm/appengine/distrib...
File dm/appengine/distributor/config.go (right):

https://chromiumcodereview.appspot.com/2347973003/diff/1/dm/appengine/distrib...
dm/appengine/distributor/config.go:53: topic =
pubsub.NewTopic(info.Get(c).TrimmedAppID(), notifyTopicSuffix)
On 2016/09/20 00:24:26, Vadim Sh. wrote:
> consider caching the flag that this work has been done already, e.g. here's
how
> luci-scheduler does it:
>
https://github.com/luci/luci-go/blob/master/scheduler/appengine/engine/engine...

I think it will make sense to do this when DM eventually does the topic creation
and permission adjustment. Right now it's just concatenating strings together
:).

https://chromiumcodereview.appspot.com/2347973003/diff/1/dm/appengine/distrib...
File dm/appengine/distributor/distributor.go (right):

https://chromiumcodereview.appspot.com/2347973003/diff/1/dm/appengine/distrib...
dm/appengine/distributor/distributor.go:15: //     record its Token.
Additionally, the distributor SHOULD subscribe to
On 2016/09/20 00:24:26, Vadim Sh. wrote:
> "should subscribe to publish on topic"
> 
> I cannot parse this.

Fixed

https://chromiumcodereview.appspot.com/2347973003/diff/1/dm/appengine/distrib...
File dm/appengine/distributor/fake/fake.go (right):

https://chromiumcodereview.appspot.com/2347973003/diff/1/dm/appengine/distrib...
dm/appengine/distributor/fake/fake.go:257: tok = MkToken(exAuth.Id)
On 2016/09/20 00:24:26, Vadim Sh. wrote:
> is it really that difficult to type two more letters to make it "MakeToken"?
:)
> I'm just curious why...

I think it's fine for a testing library... Mk is a pretty standard abbreviation.
I guess I could rename it CreateDistributorTokenFromExecutionID. When is an
abbreviation not OK?

[iannucci, 2016-09-20 00:51:42]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2016-09-20 00:51:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 01:40:17]

Description was changed from

==========
Refactor distributor API so that methods always get the Quest_Desc too.

This is so that various methods can see the original quest description body,
which can contain data directed at the distributor (or the distributor adaptor
in the case of swarming).

R=dnj@chromium.org, vadimsh@chromium.org
BUG=639975
==========

to

==========
Refactor distributor API so that methods always get the Quest_Desc too.

This is so that various methods can see the original quest description body,
which can contain data directed at the distributor (or the distributor adaptor
in the case of swarming).

R=dnj@chromium.org, vadimsh@chromium.org
BUG=639975

Committed:
https://github.com/luci/luci-go/commit/fa6f67917f657b339926828ac352e26e4d4dfb1e
==========

[commit-bot: I haz the power, 2016-09-20 01:40:19]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/fa6f67917f657b339926828ac352e26e4d4dfb1e