Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 23479017: Remove uses of GR_RELEASE. (Closed)

Created:
7 years, 3 months ago by tfarina
Modified:
7 years, 3 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove uses of GR_RELEASE. Instead of using GR_RELEASE new code should just use SK_RELEASE, like its counterpart SK_DEBUG instead of GR_DEBUG. R=bsalomon@google.com,robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=11070

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M gyp/common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrConfig.h View 1 chunk +0 lines, -10 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
please, check if I get this right. thanks,
7 years, 3 months ago (2013-09-03 02:21:43 UTC) #1
robertphillips
lgtm
7 years, 3 months ago (2013-09-03 13:55:39 UTC) #2
bsalomon
On 2013/09/03 13:55:39, robertphillips wrote: > lgtm lgtm. There is probably some cleanup that could ...
7 years, 3 months ago (2013-09-03 14:28:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/23479017/1
7 years, 3 months ago (2013-09-03 23:22:31 UTC) #4
commit-bot: I haz the power
Change committed as 11070
7 years, 3 months ago (2013-09-03 23:32:13 UTC) #5
tfarina
7 years, 3 months ago (2013-09-05 00:02:57 UTC) #6
Message was sent while issue was closed.
On 2013/09/03 14:28:23, bsalomon wrote:
> On 2013/09/03 13:55:39, robertphillips wrote:
> > lgtm
> 
> lgtm. There is probably some cleanup that could be done in skia.gyp in
chromium
> src/skia/skia.gyp

Assuming this is what you meant, I uploaded a CL here ->
https://codereview.chromium.org/23548012 for review.

Powered by Google App Engine
This is Rietveld 408576698