Source/bindings/v8/ScriptPromiseResolver.cpp - Issue 23479016: Introduce Promise mapping to the IDL generator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptPromiseResolver.cpp

Issue 23479016: Introduce Promise mapping to the IDL generator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add hasNoValue Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptPromiseResolver.cpp

diff --git a/Source/bindings/v8/ScriptPromiseResolver.cpp b/Source/bindings/v8/ScriptPromiseResolver.cpp

index 6d51b49b3b17b58908f15409937f239e3a6e65fb..8743f738e5794a679bd9e45af5070897cc0ab1f3 100644

--- a/Source/bindings/v8/ScriptPromiseResolver.cpp

+++ b/Source/bindings/v8/ScriptPromiseResolver.cpp

@@ -48,7 +48,7 @@ ScriptPromiseResolver::ScriptPromiseResolver(v8::Handle<v8::Object> creationCont

ASSERT(RuntimeEnabledFeatures::promiseEnabled());

v8::Local<v8::Object> promise, resolver;

V8PromiseCustom::createPromise(creationContext, &promise, &resolver, isolate);

- m_promise.set(isolate, promise);

+ m_promise = ScriptPromise(promise);

m_resolver.set(isolate, resolver);

}