Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 23479016: Introduce Promise mapping to the IDL generator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index d2d481b7ef8de9fed26fc84447f6f9a9378d78c0..9b5d6e45a95fa518066ba2d2b063815cf7889c69 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -427,6 +427,10 @@ sub AddIncludesForType
AddToImplIncludes("bindings/v8/SerializedScriptValue.h");
} elsif ($type eq "any" || IsCallbackFunctionType($type)) {
AddToImplIncludes("bindings/v8/ScriptValue.h");
+ } elsif ($type eq "Promise") {
+ AddToImplIncludes("bindings/v8/ScriptPromise.h");
+ } elsif ($type eq "PromiseResolver") {
+ AddToImplIncludes("bindings/v8/ScriptPromiseResolver.h");
} elsif (IsTypedArrayType($type)) {
AddToImplIncludes("bindings/v8/custom/V8${type}Custom.h");
} else {
@@ -2458,7 +2462,7 @@ sub GenerateParametersCheck
my $default = defined $parameter->extendedAttributes->{"Default"} ? $parameter->extendedAttributes->{"Default"} : "";
my $jsValue = $parameter->isOptional && $default eq "NullString" ? "argumentOrNull(args, $paramIndex)" : "args[$paramIndex]";
$parameterCheckString .= JSValueToNativeStatement($parameter->type, $parameter->extendedAttributes, $jsValue, $parameterName, " ", "args.GetIsolate()");
- if ($nativeType eq 'Dictionary') {
+ if ($nativeType eq 'Dictionary' or $nativeType eq 'ScriptPromise' or $nativeType eq 'ScriptPromiseResolver') {
$parameterCheckString .= " if (!$parameterName.isUndefinedOrNull() && !$parameterName.isObject()) {\n";
$parameterCheckString .= " throwTypeError(\"Not an object.\", args.GetIsolate());\n";
$parameterCheckString .= " return;\n";
@@ -3161,6 +3165,8 @@ sub GenerateIsNullExpression
return "!${variableName}";
} elsif ($type eq "DOMString") {
return "${variableName}.isNull()";
+ } elsif ($type eq "Promise" or $type eq "PromiseResolver") {
+ return "${variableName}.isNull()";
} else {
return "";
}
@@ -5010,6 +5016,9 @@ sub GetNativeType
return "String" if $type eq "DOMString" or IsEnumType($type);
+ return "ScriptPromise" if $type eq "Promise";
+ return "ScriptPromiseResolver" if $type eq "PromiseResolver";
+
return "Range::CompareHow" if $type eq "CompareHow";
return "DOMTimeStamp" if $type eq "DOMTimeStamp";
return "double" if $type eq "Date";
@@ -5138,6 +5147,16 @@ sub JSValueToNative
return "ScriptValue($value)";
}
+ if ($type eq "Promise") {
+ AddToImplIncludes("bindings/v8/ScriptPromise.h");
+ return "ScriptPromise($value)";
+ }
+
+ if ($type eq "PromiseResolver") {
+ AddToImplIncludes("bindings/v8/ScriptPromiseResolver.h");
+ return "ScriptPromiseResolver($value, $getIsolate)";
+ }
+
if ($type eq "NodeFilter") {
return "toNodeFilter($value, $getIsolate)";
}
@@ -5269,6 +5288,8 @@ sub IsWrapperType
return 0 if IsEnumType($type);
return 0 if IsPrimitiveType($type);
return 0 if $type eq "DOMString";
+ return 0 if $type eq "Promise";
+ return 0 if $type eq "PromiseResolver";
return !$nonWrapperTypes{$type};
}
@@ -5418,7 +5439,7 @@ sub NativeToJSValue
return "$indent$receiver v8::Number::New($nativeValue);";
}
- if ($nativeType eq "ScriptValue") {
+ if ($nativeType eq "ScriptValue" or $nativeType eq "ScriptPromise" or $nativeType eq "ScriptPromiseResolver") {
return "${indent}v8SetReturnValue(${getCallbackInfo}, ${nativeValue}.v8Value());" if $isReturnValue;
return "$indent$receiver $nativeValue.v8Value();";
}
@@ -5688,6 +5709,8 @@ sub IsRefPtrType
return 0 if GetArrayType($type);
return 0 if GetSequenceType($type);
return 0 if $type eq "DOMString";
+ return 0 if $type eq "Promise";
+ return 0 if $type eq "PromiseResolver";
return 0 if IsCallbackFunctionType($type);
return 0 if IsEnumType($type);
return 0 if IsUnionType($type);

Powered by Google App Engine
This is Rietveld 408576698