Create a PDF password dialog for Views.

Create a PDF password dialog for Views.

BUG=54748
TEST=load a password-protected PDF on Windows, see fancy new UI

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223509

[Avi (use Gerrit), 2013-09-15 01:11:32]

Scott: You're a Views dude, yes? This is, um, heavily inspired by
TabModalConfirmDialogViews. The UI you get is http://imgur.com/gdsNMxB

Tom: FYI

[Avi (use Gerrit), 2013-09-15 01:15:53]

Elliot: At the end of August I asked you about Linux switching to Views. This is
FYI for you in that once it does you can rip this out. Does this #ifdef look OK?

[sky, 2013-09-16 17:18:38]

LGTM

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
File chrome/browser/ui/views/pdf_password_dialog.cc (right):

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
chrome/browser/ui/views/pdf_password_dialog.cc:23: class PDFPasswordDialogViews
: public views::DialogDelegate {
Add a description.

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
chrome/browser/ui/views/pdf_password_dialog.cc:63: callback_(callback) {
nit: initialize dialog_ to NULL in the member list.

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
chrome/browser/ui/views/pdf_password_dialog.cc:83:
message_box_view_->text_box()->RequestFocus();
Override GetInitiallyFocusedView instead.

[Elliot Glaysher, 2013-09-16 17:30:30]

Your ifdefs for GTK LGTM. We're hoping to launch linux_aura in the M32
timeframe, so you're right that you shouldn't bother.

[Avi (use Gerrit), 2013-09-16 18:57:14]

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
File chrome/browser/ui/views/pdf_password_dialog.cc (right):

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
chrome/browser/ui/views/pdf_password_dialog.cc:23: class PDFPasswordDialogViews
: public views::DialogDelegate {
On 2013/09/16 17:18:38, sky wrote:
> Add a description.

Done.

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
chrome/browser/ui/views/pdf_password_dialog.cc:63: callback_(callback) {
On 2013/09/16 17:18:38, sky wrote:
> nit: initialize dialog_ to NULL in the member list.

Done.

https://codereview.chromium.org/23478036/diff/1/chrome/browser/ui/views/pdf_p...
chrome/browser/ui/views/pdf_password_dialog.cc:83:
message_box_view_->text_box()->RequestFocus();
On 2013/09/16 17:18:38, sky wrote:
> Override GetInitiallyFocusedView instead.

Done.

[commit-bot: I haz the power, 2013-09-16 19:00:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/23478036/12001

[commit-bot: I haz the power, 2013-09-17 01:51:10]

Change committed as 223509